Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CycleFold #273

Merged
merged 77 commits into from
Mar 22, 2024
Merged

CycleFold #273

merged 77 commits into from
Mar 22, 2024

Commits on Mar 7, 2024

  1. skeleton

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e63ea22 View commit details
    Browse the repository at this point in the history

  2. (wip) scalar <-> base confusion

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3f1c2bc View commit details
    Browse the repository at this point in the history

  3. (wip) fix W_new def

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    24eb599 View commit details
    Browse the repository at this point in the history

  4. (wip) fixed base <-> scalar confusion

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9b0c6a9 View commit details
    Browse the repository at this point in the history

  5. (wip) new gadget scaffolding and allocated witnesses

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    49fe8e4 View commit details
    Browse the repository at this point in the history

  6. (wip) fix prove_step

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    600e601 View commit details
    Browse the repository at this point in the history

  7. (wip) synthesize_non_base_case

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    58c528f View commit details
    Browse the repository at this point in the history

  8. (wip) synthesize

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3b373c8 View commit details
    Browse the repository at this point in the history

  9. (wip) synthesize_base_case

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5ec2882 View commit details
    Browse the repository at this point in the history

  10. (wip) fix absorbs

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e1adb35 View commit details
    Browse the repository at this point in the history

  11. (wip) stuck

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fd5f5b9 View commit details
    Browse the repository at this point in the history

  12. (wip) CommitmentKey macro

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e324109 View commit details
    Browse the repository at this point in the history

  13. (wip) some gadgets filled

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9b68ff5 View commit details
    Browse the repository at this point in the history

  14. (wip) some more progress

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    dd60109 View commit details
    Browse the repository at this point in the history

  15. (wip) Gadgets done, some cleanup

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    de9fbbe View commit details
    Browse the repository at this point in the history

  16. (wip) Scalar <-> Base confusion in verify

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bdcd68d View commit details
    Browse the repository at this point in the history

  17. it builds!

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ea69936 View commit details
    Browse the repository at this point in the history

  18. make clippy happy

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    56e0b59 View commit details
    Browse the repository at this point in the history

  19. Delete RecursiveSNARKTrait and cleanup

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bf01a0b View commit details
    Browse the repository at this point in the history

  20. refactor: Refactor data types and function signatures in Cyclefold mo… 

    …dule

- Updated and harmonized data type usage in `cyclefold/gadgets.rs`, `cyclefold/circuit.rs`, and `cyclefold/nova_circuit.rs`
- Replaced `AllocatedPoint` with `AllocatedEmulPoint`, `AllocatedRelaxedR1CSInstance` with `AllocatedEmulRelaxedR1CSInstance` to avoid confusion, and simplified required bounds,
- Refactored `cyclefold/gadgets.rs` to remove use of needless bounds,
- no `CurveCycleEquipped` bound was used anywhere in this commit
    @huitseeker @mpenciak
    huitseeker authored and mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    787adda View commit details
    Browse the repository at this point in the history

  21. refactor: remove uneeded params in PublicParams, RecursiveSNARK

    @huitseeker @mpenciak
    huitseeker authored and mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ecdc1c2 View commit details
    Browse the repository at this point in the history

  22. refactor: Remove option in CycleFoldInputs, remove a few needless typ… 

    …es in tests
    @huitseeker @mpenciak
    huitseeker authored and mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b09059a View commit details
    Browse the repository at this point in the history

  23. test: use expect_test on brittle test

    @huitseeker @mpenciak
    huitseeker authored and mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a169a23 View commit details
    Browse the repository at this point in the history

  24. chore: update expect tests

    @huitseeker @mpenciak
    huitseeker authored and mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    40952a2 View commit details
    Browse the repository at this point in the history

  25. (wip) addressing comments

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    14dc4f1 View commit details
    Browse the repository at this point in the history

  26. (wip) add recursive_snark test

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    72a25cc View commit details
    Browse the repository at this point in the history

  27. (wip) add generic bounds for allocatedr1csinstances

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d7e30cf View commit details
    Browse the repository at this point in the history

  28. make the cyclefold test more **fun**

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7f488bc View commit details
    Browse the repository at this point in the history

  29. fix cyclefold circuit IO

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ca4f46e View commit details
    Browse the repository at this point in the history

  30. uncomment num_io cyclefold check

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a3a722d View commit details
    Browse the repository at this point in the history

  31. update constant

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6b46449 View commit details
    Browse the repository at this point in the history

  32. fix link

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    eb92e4e View commit details
    Browse the repository at this point in the history

  33. cleanup output

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    87d1695 View commit details
    Browse the repository at this point in the history

  34. last couple circuit pieces

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7697e64 View commit details
    Browse the repository at this point in the history

  35. add comm_T to inputs and add cyclefold IO checks

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6463bd9 View commit details
    Browse the repository at this point in the history

  36. fix ro absorb numbers

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7cb4a10 View commit details
    Browse the repository at this point in the history

  37. remove extra unneeded comm_T allocation

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ee8cf69 View commit details
    Browse the repository at this point in the history

  38. properly constrain always_equal in mult_mod and red_mod

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    315d1ce View commit details
    Browse the repository at this point in the history

  39. some allocation fixes

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    42830f5 View commit details
    Browse the repository at this point in the history

  40. eliminate clone

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    178bb1f View commit details
    Browse the repository at this point in the history

  41. make RO absorb numbers make sense

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ceb9c6b View commit details
    Browse the repository at this point in the history

  42. fix cyclefold scalar alloc

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6a63178 View commit details
    Browse the repository at this point in the history

  43. chore: update Bn256Engine -> Bn256EngineKZG

    @huitseeker @mpenciak
    huitseeker authored and mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    734dead View commit details
    Browse the repository at this point in the history

  44. chore: run clippy

    @huitseeker @mpenciak
    huitseeker authored and mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fb85877 View commit details
    Browse the repository at this point in the history

  45. update expect_tests

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ab73fa9 View commit details
    Browse the repository at this point in the history

  46. fix EmulatedCurveParam allocation

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d1afdea View commit details
    Browse the repository at this point in the history

  47. fix nifs RO absorb count

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e47d8ae View commit details
    Browse the repository at this point in the history

  48. make test_augmented_circuit_size an expect_test

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3a3558c View commit details
    Browse the repository at this point in the history

  49. fix: typo

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8d23795 View commit details
    Browse the repository at this point in the history

  50. fix: RecursiveSNARK::new sets i to 0

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f630faf View commit details
    Browse the repository at this point in the history

  51. fix: Fix RO absorb count in verify

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    695ff0c View commit details
    Browse the repository at this point in the history

  52. fix: RecursiveSNARK::new should set r_*_primary to default values

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bd3076d View commit details
    Browse the repository at this point in the history

  53. u <-> U in folding data Alloc

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2aebeb3 View commit details
    Browse the repository at this point in the history

  54. fix: add trivialization for cyclefold checks in base case

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bccabb6 View commit details
    Browse the repository at this point in the history

  55. make prove_verify test more fun

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8cdfea3 View commit details
    Browse the repository at this point in the history

  56. fix: fix hashing order

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a2d1ed8 View commit details
    Browse the repository at this point in the history

  57. fix: r_bools was always None

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7445a59 View commit details
    Browse the repository at this point in the history

  58. make prove_verify test longer

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4fab7cb View commit details
    Browse the repository at this point in the history

  59. clippy

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    051bab8 View commit details
    Browse the repository at this point in the history

  60. test_augmented_circuit_size should check synthesis works

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b4dc789 View commit details
    Browse the repository at this point in the history

  61. chore: fix rebase

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    40abbec View commit details
    Browse the repository at this point in the history

  62. chore: bump msrv

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    07d92c9 View commit details
    Browse the repository at this point in the history

  63. chore: cleanup, documentation, and split cyclefold test

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    90cc205 View commit details
    Browse the repository at this point in the history

  64. fix: Fix CycleFold circuit IO to only have arity 4 

    Also fix CycleFold folding soundness issue by absorbing running instance
    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    13d146f View commit details
    Browse the repository at this point in the history

  65. chore: update cyclefold_circuit_size expecttest

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    59577f6 View commit details
    Browse the repository at this point in the history

  66. fix: fix RO absorb counts and logic

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e735e9e View commit details
    Browse the repository at this point in the history

  67. chore: update cyclefold primary circuit size expecttest

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6381ccf View commit details
    Browse the repository at this point in the history

  68. chore: cleanup and docs

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0fafbeb View commit details
    Browse the repository at this point in the history

  69. fix: fix rebase

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f912350 View commit details
    Browse the repository at this point in the history

  70. chore: fix clippy lints

    @mpenciak
    mpenciak committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0232b8d View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. fix: constrain AllocatedEmulPoint::default

    @mpenciak
    mpenciak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a123ba3 View commit details
    Browse the repository at this point in the history

  2. tidy: use AllocatedNum::add

    @mpenciak
    mpenciak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8f0f425 View commit details
    Browse the repository at this point in the history

  3. chore: fix rebase errors in src/gadgets

    @mpenciak
    mpenciak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    67f9a92 View commit details
    Browse the repository at this point in the history

  4. fix: fix import

    @mpenciak
    mpenciak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5d48fc6 View commit details
    Browse the repository at this point in the history

  5. chore: update expecttests

    @mpenciak
    mpenciak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b83d57c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. tidy: add new constant

    @mpenciak
    mpenciak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    938877b View commit details
    Browse the repository at this point in the history

  2. tidy: Cyclefold -> CycleFold

    @mpenciak
    mpenciak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    497aef7 View commit details
    Browse the repository at this point in the history