fix: remove needless visibility modifiers #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
approved these changes
Jan 5, 2024
Merged
via the queue into
argumentcomputer:dev
with commit Jan 6, 2024
a63bf11
17 of 18 checks passed
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently introduced quite a few visibility modifiers, here are the ones that are not needed (found through brute force).
The experimental nature of our repo will probably make the next release a major bump, so backwards-compatibility probably isn't the priority.
This will also help with microsoft/Nova#283