Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update argocd versions used for testing #443

Closed
wants to merge 2 commits into from
Closed

feat: update argocd versions used for testing #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
342ce2c
feat: update argocd versions used for testing
the-technat Oct 7, 2024
32e569d
Merge branch 'main' into feat/update-testing-versions
mkilchhofer Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"image":"mcr.microsoft.com/devcontainers/go"}
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
strategy:
fail-fast: false
matrix:
argocd_version: ["v2.8.13", "v2.9.9", "v2.10.4"]
argocd_version: ["v2.10.17", "v2.11.9", "v2.12.4"]
steps:
- name: Check out code
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
Expand Down
2 changes: 1 addition & 1 deletion GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ARGOCD_INSECURE?=true
ARGOCD_SERVER?=127.0.0.1:8080
ARGOCD_AUTH_USERNAME?=admin
ARGOCD_AUTH_PASSWORD?=acceptancetesting
ARGOCD_VERSION?=v2.9.3
ARGOCD_VERSION?=v2.12.4

export

Expand Down
2 changes: 1 addition & 1 deletion scripts/testacc_prepare_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -e

export PATH=$PATH:.

argocd_version=${ARGOCD_VERSION:-v2.8.13}
argocd_version=${ARGOCD_VERSION:-v2.12.4}
k8s_version=${ARGOCD_KUBERNETES_VERSION:-v1.27.11}
Copy link
Collaborator

@onematchfox onematchfox Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: You may want to leave this one alone for the time being. It should generally match a version supported across all of the ArgoCD versions being tested.

https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/#tested-versions

Copy link
Collaborator Author

@the-technat the-technat Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the link, forgot that one. Changed the k8s version back to 1.27.11 as this is supported by Argo CD 2.10, 2.11 and 2.12.


echo "\n--- Clearing current kube context\n"
Expand Down
Loading