Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [ENHANCEMENT] Improve performance with persistent storage #5585

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

frascuchon
Copy link
Member

Description

This PR is a test to improve the performance when running the argilla server in HF Spaces with persistent storage enabled.

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (e43c9bf) to head (b4a23f9).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5585   +/-   ##
========================================
  Coverage    91.22%   91.22%           
========================================
  Files          145      145           
  Lines         6030     6030           
========================================
  Hits          5501     5501           
  Misses         529      529           
Flag Coverage Δ
argilla-server 91.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -15,4 +15,10 @@ export USERNAME="${USERNAME:-$DEFAULT_USERNAME}"
DEFAULT_PASSWORD=$(pwgen -s 16 1)
export PASSWORD="${PASSWORD:-$DEFAULT_PASSWORD}"

# Copy the backup file to the correct location
cp -r /data/argilla/backup/* /data/* || true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Create a backup of the existing files first

@frascuchon frascuchon changed the title [DRAFT] [ENHANCEMENT] Improve performance with persistent storage [ENHANCEMENT] Improve performance with persistent storage Oct 9, 2024
@frascuchon frascuchon changed the title [ENHANCEMENT] Improve performance with persistent storage [DRAFT] [ENHANCEMENT] Improve performance with persistent storage Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants