Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

[TASK] Migrate GET /api/_status endpoint to GET /api/v1/status #164

Closed
Tracked by #4773
jfcalvo opened this issue May 10, 2024 · 0 comments · Fixed by #165
Closed
Tracked by #4773

[TASK] Migrate GET /api/_status endpoint to GET /api/v1/status #164

jfcalvo opened this issue May 10, 2024 · 0 comments · Fixed by #165
Assignees

Comments

@jfcalvo
Copy link
Member

jfcalvo commented May 10, 2024

No description provided.

@jfcalvo jfcalvo self-assigned this May 10, 2024
@jfcalvo jfcalvo transferred this issue from argilla-io/argilla May 10, 2024
@jfcalvo jfcalvo linked a pull request May 10, 2024 that will close this issue
15 tasks
jfcalvo added a commit that referenced this issue May 13, 2024
# Description

This PR add changes to migrate `/api/_status` endpoint to
`/api/v1/status` endpoint.

The changes added in this PR compared to the endpoint from API v0:
* Instead of `mem_info` attribute name we are using now `memory`.
* I'm not using the info service code because it has a lot of accidental
complexity. Instead I have created a new `info` context with three
functions that returns the Argilla version, ElasticSearch and Memory
status. (Once we delete old endpoints we can remove the service code).

Closes #164 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x] Adding tests for the new endpoint.

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@jfcalvo jfcalvo closed this as completed May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant