-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Migrate used endpoints from API v0 to v1 #4773
Milestone
Comments
15 tasks
jfcalvo
added a commit
to argilla-io/argilla-server
that referenced
this issue
May 14, 2024
# Description Feature branch for migrating API endpoints from v0 to v1. Refs argilla-io/argilla#4773 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** - [x] Adding new tests. **Checklist** - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
13 tasks
frascuchon
added a commit
that referenced
this issue
Jun 4, 2024
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR setup the argilla-sdk project. This PR only copy the code base from the [argilla-python repository](https://github.com/argilla-io/argilla-python). ~~No changes in package definition or docs have been applied yet.~~ UPDATED: The only change is [this line](https://github.com/argilla-io/argilla/blob/feat/add-new-sdk-project/argilla-sdk/src/argilla_sdk/_helpers/_uuid.py#L61) which raise an ruff error when applying commit hooks. ## Update The code on this PR won't work with the server version on `feat/v2.0.0` until we resolve SDK tasks for the issue #4773. For the sake of the review complexity, I would prefer to tackle this migration as a separate PR. After those changes, the new SDK will still be fully compatible with argilla server 1.29.0. Closes #4888 Closes #4895 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [X] New feature (non-breaking change which adds functionality) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I added relevant documentation - [ ] I followed the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: David Berenstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue will include all the changes necessary to move some functionality that is not present on API v0 to API v1. Some changes will be required on the UI too so new endpoints from API v1 are used too.
Server Tasks
/api/me
endpoin to/api/v1/me
argilla-server#139/api/users
endpoint to/api/v1/users
argilla-server#141POST /api/users
endpoint toPOST /api/v1/users
argilla-server#145DELETE /api/users/:user_id
endpoint toDELETE /api/v1/users/:user_id
argilla-server#147POST /api/workspaces
endpoin toPOST /api/v1/workspaces
argilla-server#149GET /api/workspaces/:workspace_id/users
endpoin toGET /api/v1/workspaces/:workspace_id/users
argilla-server#152POST /api/workspaces/:workspace_id/users/:user_id
endpoint argilla-server#155DELETE /api/workspaces/:workspace_id/users/:user_id
endpoint argilla-server#157GET /api/_info
endpoint toGET /api/v1/version
argilla-server#161GET /api/_status
endpoint toGET /api/v1/status
argilla-server#164Frontend Tasks
POST /api/v1/token
endpoint #4777GET /api/v1/me
endpoint #4779GET /api/v1/users
endpoint (if necessary) #4781GET /api/v1/version
endpoint (if necessary) #4814New SDK Tasks
GET /api/v1/me
#4843POST /api/v1/users
#4844GET /api/v1/users
#4845GET /api/v1/workspaces/:workspace_id/users
#4846POST /api/v1/workspaces/:workspace_id/users
#4847DELETE /api/v1/workspaces/:workspace_id/users/:user_id
#4848POST /api/v1/workspaces
#4849The text was updated successfully, but these errors were encountered: