Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update with instrumentation module #27

Merged
merged 27 commits into from
Oct 7, 2024

Conversation

sdiazlor
Copy link
Contributor

@sdiazlor sdiazlor commented Sep 17, 2024

screencapture-localhost-6900-dataset-3eda76b9-d868-418f-bdba-cf2bde9a5176-annotation-mode-2024-10-02-01_56_58

pyproject.toml Outdated Show resolved Hide resolved
src/argilla_llama_index/llama_index_handler.py Outdated Show resolved Hide resolved
src/argilla_llama_index/llama_index_handler.py Outdated Show resolved Hide resolved
@davidberenstein1957
Copy link
Member

Looking great @sdiazlor, let's wait for some final feedback from llama-index and then we can start posting about it.

LICENSE_HEADER Outdated Show resolved Hide resolved
@sdiazlor
Copy link
Contributor Author

sdiazlor commented Oct 2, 2024

I updated the integration to handle events as I found some bugs when running the chat_engine or, in this case, the workflows. The usage is similar, it just needs to also be added as an event_handler cc @davidberenstein1957 @burtenshaw

@sdiazlor sdiazlor merged commit 7172ed2 into main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants