Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DpsPowerSupply #5185

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

DpsPowerSupply #5185

wants to merge 5 commits into from

Conversation

arielzw
Copy link
Contributor

@arielzw arielzw commented Oct 2, 2024

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 October 2, 2024 00:03
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Hi @arielzw.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: submission Add library to the list labels Oct 2, 2024
@github-actions github-actions bot removed the request for review from per1234 October 2, 2024 00:13
Copy link
Contributor

github-actions bot commented Oct 2, 2024

ERROR: Arduino Lint found errors with https://github.com/arielzw/DpsPowerSupply:

Linting library in DpsPowerSupply
ERROR: Library name DpsPowerSupply not found in the Library Manager index. Library names are not allowed to change after
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in DpsPowerSupply/examples/DPS_Library

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @arielzw
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 October 2, 2024 00:13
@arielzw
Copy link
Contributor Author

arielzw commented Oct 2, 2024

I was change the url of the repository
Previous: DPS-Power-Supply-library-for-Arduino
Now: DpsPowerSupply

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arielzw.

Previous: DPS-Power-Supply-library-for-Arduino
Now: DpsPowerSupply

I think you must have gotten it backwards. If I open this URL in my browser:

https://github.com/arielzw/DpsPowerSupply

I am redirected to this URL:

https://github.com/arielzw/DPS-Power-Supply-library-for-Arduino

This tells me that you have renamed the repository from DpsPowerSupply to DPS-Power-Supply-library-for-Arduino (GitHub automatically sets up a redirect from the old repository name to the new name). So the change you propose here would actually be a regression, since the current URL is the one we already have (https://github.com/arielzw/DPS-Power-Supply-library-for-Arduino).

Please comment here to let me know how to proceed.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for information More information must be provided before work can proceed topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants