Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #3750

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/manage-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
--output "${{ steps.configuration.outputs.path }}/{}" \
--header "Authorization: token $GITHUB_TOKEN" \
--header "Accept: application/vnd.github.v3.{}" \
https://api.github.com/repos/${{ github.repository_owner }}/${{ github.event.repository.name }}/pulls/${{ github.event.pull_request.number }}${{ github.event.issue.number }}

Check warning on line 106 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

106:121 [line-length] line too long (189 > 120 characters)

Check warning on line 106 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

106:121 [line-length] line too long (189 > 120 characters)
' \
::: \
${{ env.DIFF_IDENTIFIER }} \
Expand All @@ -111,10 +111,10 @@

- name: Get head SHA of diff
id: head
run: echo "::set-output name=head::$(jq -c .head.sha "${{ steps.configuration.outputs.path }}/${{ env.JSON_IDENTIFIER }}")"

Check warning on line 114 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

114:121 [line-length] line too long (131 > 120 characters)

Check warning on line 114 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

114:121 [line-length] line too long (131 > 120 characters)

- name: Upload diff file to workflow artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: ${{ steps.configuration.outputs.path }}/${{ steps.configuration.outputs.filename }}
name: ${{ steps.configuration.outputs.artifact }}
Expand All @@ -140,7 +140,7 @@
id: download-parser
uses: carlosperate/download-file-action@v2
with:
file-url: https://github.com/arduino/library-registry-submission-parser/releases/download/${{ env.SUBMISSION_PARSER_VERSION }}/parser

Check warning on line 143 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

143:121 [line-length] line too long (143 > 120 characters)

Check warning on line 143 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

143:121 [line-length] line too long (143 > 120 characters)
location: ${{ runner.temp }}

- name: Download diff
Expand Down Expand Up @@ -168,7 +168,7 @@
# certain workflow fields.
echo "::set-output name=type::$(echo "$REQUEST" | jq -r -c '.type')"
echo "::set-output name=error::$(echo "$REQUEST" | jq -r -c '.error')"
echo "::set-output name=arduinoLintLibraryManagerSetting::$(echo "$REQUEST" | jq -r -c '.arduinoLintLibraryManagerSetting')"

Check warning on line 171 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

171:121 [line-length] line too long (134 > 120 characters)

Check warning on line 171 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

171:121 [line-length] line too long (134 > 120 characters)
echo "::set-output name=submissions::$(echo "$REQUEST" | jq -c '.submissions')"
echo "::set-output name=index-entry::$(echo "$REQUEST" | jq -r -c '.indexEntry')"
echo "::set-output name=indexer-logs-urls::$(echo "$REQUEST" | jq -r -c '.indexerLogsURLs')"
Expand Down Expand Up @@ -340,7 +340,7 @@
issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }}
body: |
|
[Arduino Lint](https://github.com/arduino/arduino-lint) has suggestions for possible improvements to ${{ matrix.submission.submissionURL }}:

Check warning on line 343 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

343:121 [line-length] line too long (152 > 120 characters)

Check warning on line 343 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

343:121 [line-length] line too long (152 > 120 characters)

```
${{ steps.read-lint-report.outputs.text-report }}
Expand All @@ -360,7 +360,7 @@
issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }}
body: |
|
${{ env.ERROR_MESSAGE_PREFIX }}[Arduino Lint](https://github.com/arduino/arduino-lint) found errors with ${{ matrix.submission.submissionURL }}:

Check warning on line 363 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

363:121 [line-length] line too long (156 > 120 characters)

Check warning on line 363 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

363:121 [line-length] line too long (156 > 120 characters)

```
${{ steps.read-lint-report.outputs.text-report }}
Expand All @@ -380,7 +380,7 @@
# So it's necessary to use an alternative means of indicating that at least one submission failed the checks.
- name: Upload failure flag artifact
if: env.PASS == 'false'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
path: ${{ env.FAIL_FLAG_PATH }}
Expand Down Expand Up @@ -488,7 +488,7 @@
git add --update "$INDEX_SOURCE_FILE_PATH"
echo \
-e \
"Add submission # ${{ github.event.pull_request.number }}${{ github.event.issue.number }}\n\n${{ github.event.repository.html_url }}/pull/${{ github.event.pull_request.number }}${{ github.event.issue.number }}" \

Check warning on line 491 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

491:121 [line-length] line too long (224 > 120 characters)

Check warning on line 491 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

491:121 [line-length] line too long (224 > 120 characters)
| \
git commit \
--file -
Expand Down Expand Up @@ -532,7 +532,7 @@
issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }}
body: |
|
${{ env.ERROR_MESSAGE_PREFIX }}Your submission meets all requirements. However, the pull request could not be merged.

Check warning on line 535 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

535:121 [line-length] line too long (129 > 120 characters)

Check warning on line 535 in .github/workflows/manage-prs.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output

535:121 [line-length] line too long (129 > 120 characters)

Please follow this guide to sync your fork:
https://docs.github.com/github/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }}

- name: Pass configuration files to next job via workflow artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: |
*.yaml
Expand Down
Loading