Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore window.titleBarStyle and breadcrumbs.enabled #1870

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 9, 2023

Motivation

This PR partially fixes #1733 by restoring the default Theia behavior of the window.titleBarStyle (on Windows and Linux) and breadcrumbs.enabled preferences.

Change description

  • breadcrumbs.enabled should enable the breadcrumbs on all platforms. By default, it is disabled in IDE2.

  • The window.titleBarStyle preference should be verified together with the window.menuBarVisibility values. The custom menu has special handling from Theia when the app is running in full-screen mode:

    Screen Shot 2023-02-15 at 15 53 11

Other information

Ref: #1733

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 10, 2023
@kittaakos kittaakos self-assigned this Feb 15, 2023
@kittaakos kittaakos changed the base branch from #1826 to main February 15, 2023 13:21
Akos Kitta added 2 commits February 15, 2023 14:32
@kittaakos kittaakos changed the title fix: restore window.titleBarStyle fix: restore window.titleBarStyle and breadcrumbs.enabled Feb 15, 2023
@kittaakos kittaakos mentioned this pull request Sep 19, 2023
3 tasks
@kittaakos kittaakos removed their assignment Feb 23, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
3 participants