Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ping WiFiS3 #264

Closed
wants to merge 4 commits into from
Closed

add ping WiFiS3 #264

wants to merge 4 commits into from

Conversation

paulvha
Copy link

@paulvha paulvha commented Feb 14, 2024

see issues topic 251
needs to be used in combination with a pull request on bridge software.
the WifiCommands.h used to be a symbolic link but that was not pulled in. Hence it is now a seperate file.

regards,
Paul

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024

CLA assistant check
All committers have signed the CLA.

@JAndrassy
Copy link
Contributor

JAndrassy commented Feb 14, 2024

this core has 3 networking libraries so please add WiFiS3 into the title. (the other two are WiFi and Ethernet for Portenta C33)
please remove all the white space change differences (I know there are weird trailing spaces in the original source)

maybe just

loat CWifi::ping(IPAddress ip, unsigned int count) {
/* -------------------------------------------------------------------------- */
  return ping(ip.toString().c_str(), count);
}

?
don't commit WiFiCommand.h. it is a symbolic link

@paulvha paulvha changed the title add ping add ping WiFiS3 Feb 14, 2024
@per1234 per1234 linked an issue Feb 14, 2024 that may be closed by this pull request
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 14, 2024
@per1234
Copy link
Collaborator

per1234 commented Feb 15, 2024

Hi @paulvha. Thanks so much for your pull request!

Unfortunately, the @CLAassistant bot has not been able to validate the pull request meets Arduino's Contributor License Agreement (CLA) requirement.

This is likely caused by the email address used in your local Git settings not being associated with your GitHub account. Please follow these instructions to resolve the issue:

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate.

@paulvha
Copy link
Author

paulvha commented Feb 15, 2024

I have added [email protected] (it already had [email protected]) and verified. set the default to hotmail.com. please anything else I can / need to do to perform a re-run.
regards,
Paul

@paulvha
Copy link
Author

paulvha commented Feb 15, 2024

included also WiFiTime() now. Somehow the changes in Wifi.cpp and Wifi.h are not taken into account when the test compile is done online

@paulvha paulvha closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WiFi.ping() function on WiFiS3 library doesn't exist
4 participants