Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethernet - complete API (setHostname, dnsIP(n), hostByName, ...) #221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Dec 21, 2023

For legacy Ethernet API, setDnsServerIP was missing.
Many Ethernet libraries have now the getters and setters as the WiFi API: setDNS, dnsIP(n), macAddress
hostByName is useful to split blocking client.connect(gost, port) into to steps or debug DNS.

setDNS(dns1, dns2) is in the PR #200
that PR is important for dnsServerIP and dnsIP(n) too.

tested with LegacyEthernetTest

overview of API in librarries

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 21, 2023
@per1234
Copy link
Collaborator

per1234 commented Dec 21, 2023

Thanks @JAndrassy! I'm just commenting to explain that the failure of the "Compile Examples" workflow run is caused by a bug in Arduino CLI; not by any problem introduced by this PR. So don't worry about that failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants