Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LwipServer - manage connections as LwipClient so a copy always exists for shared_ptr #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Dec 15, 2023

I made the changes discussed in #207
what do you think?

If this is not merged, I can do a separate PR for the Wifi/Ethernet Client and Server changes. They reduce code duplication. Maybe even the 'facades' could be only a typedef like typedef lwipClient WiFiClient, but I am not sure about all consequences of changing a class to a typedef.

@JAndrassy JAndrassy marked this pull request as draft December 15, 2023 16:27
@JAndrassy JAndrassy force-pushed the lwipclient_shared_ptr_with_server branch from 4f02c81 to af09d06 Compare December 15, 2023 16:30
@JAndrassy JAndrassy marked this pull request as ready for review December 15, 2023 21:43
@per1234 per1234 added the topic: code Related to content of the project itself label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants