Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous return value of EthernetClient::write() #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix erroneous return value of EthernetClient::write() #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/EthernetClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ size_t EthernetClient::write(uint8_t b)
size_t EthernetClient::write(const uint8_t *buf, size_t size)
{
if (_sockindex >= MAX_SOCK_NUM) return 0;
if (Ethernet.socketSend(_sockindex, buf, size)) return size;
setWriteError();
return 0;
const size_t bytesSent = Ethernet.socketSend(_sockindex, buf, size);
if (!bytesSent) setWriteError();
return bytesSent;
}

int EthernetClient::available()
Expand Down
2 changes: 1 addition & 1 deletion src/socket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ static void write_data(uint8_t s, uint16_t data_offset, const uint8_t *data, uin

/**
* @brief This function used to send the data in TCP mode
* @return 1 for success else 0.
* @return number of bytes sent for success 0 in case of error.
*/
uint16_t EthernetClass::socketSend(uint8_t s, const uint8_t * buf, uint16_t len)
{
Expand Down