Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup materials #792

Merged
merged 6 commits into from
Jul 9, 2023
Merged

Cleanup materials #792

merged 6 commits into from
Jul 9, 2023

Conversation

grospelliergilles
Copy link
Member

@grospelliergilles grospelliergilles commented Jul 9, 2023

  • make a private version of public methods intented to be internal to Arcane.
  • make the public version deprecated
  • move MaterialComponentData in directory arcane/materials/internal

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Jul 9, 2023
@grospelliergilles grospelliergilles self-assigned this Jul 9, 2023
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 89.65% and no project coverage change.

Comparison is base (fae37fd) 72.31% compared to head (ef48eb8) 72.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   72.31%   72.32%           
=======================================
  Files        1630     1630           
  Lines      122497   122498    +1     
=======================================
+ Hits        88588    88595    +7     
+ Misses      33909    33903    -6     
Impacted Files Coverage Δ
...src/arcane/core/materials/MeshComponentPartData.cc 94.28% <ø> (ø)
arcane/src/arcane/materials/internal/AllEnvData.h 100.00% <ø> (ø)
arcane/src/arcane/materials/AllEnvData.cc 78.13% <57.14%> (ø)
arcane/src/arcane/materials/MeshComponentData.cc 95.55% <87.50%> (ø)
arcane/src/arcane/materials/MeshMaterial.cc 91.22% <87.50%> (ø)
arcane/src/arcane/materials/MeshEnvironment.cc 92.77% <93.75%> (ø)
...c/arcane/accelerator/RunCommandMaterialEnumerate.h 90.76% <100.00%> (ø)
...e/src/arcane/core/materials/ComponentItemVector.cc 89.18% <100.00%> (ø)
...ne/src/arcane/core/materials/ComponentItemVector.h 90.00% <100.00%> (-0.91%) ⬇️
...rc/arcane/core/materials/ComponentItemVectorView.h 90.47% <100.00%> (+1.00%) ⬆️
... and 7 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@grospelliergilles grospelliergilles merged commit 05af9ad into main Jul 9, 2023
45 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-cleanup-materials3 branch July 19, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant