Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'MaterialHeat' test #790

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

grospelliergilles
Copy link
Member

  • separate the compute loop in several phases
  • use only one MeshMaterialModifier instance to do all the updates
  • add flag OptimizeMultiMaterialPerEnvironment to material modification optimization.

@grospelliergilles grospelliergilles added enhancement New feature or request arcane Arcane Component labels Jul 7, 2023
@grospelliergilles grospelliergilles self-assigned this Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 98.11% and project coverage change: +0.01 🎉

Comparison is base (be9c936) 72.27% compared to head (483e1ea) 72.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
+ Coverage   72.27%   72.29%   +0.01%     
==========================================
  Files        1629     1629              
  Lines      122423   122470      +47     
==========================================
+ Hits        88487    88543      +56     
+ Misses      33936    33927       -9     
Impacted Files Coverage Δ
...ceapart/src/arcane/tests/MaterialHeatTestModule.cc 96.46% <98.11%> (+0.41%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@grospelliergilles grospelliergilles merged commit 8c78297 into main Jul 7, 2023
44 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-improve-material-heat-test branch July 12, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant