[arcane,std] Fix read of single point element in MSH reader #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ui n'ont qu'un noeud (dont le type est 15). Pour ces éléments, il y a deux valeurs sur la ligne. On prenait comme uniqueId() du noeud la première valeur alors qu'il faut prendre la seconde.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 72.20% 72.22% +0.01%
==========================================
Files 1626 1626
Lines 122215 122228 +13
==========================================
+ Hits 88249 88277 +28
+ Misses 33966 33951 -15
☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-fix-msh-reader-for-single-point-element
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is two values for these elements in
mshformat. We were using the first value to get theuniqueId()of the node but the good value is the second one.