Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON format for metadata in 'VariableMng' #779

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

grospelliergilles
Copy link
Member

This format is not used at the moment.

@grospelliergilles grospelliergilles added enhancement New feature or request arcane Arcane Component labels Jun 30, 2023
@grospelliergilles grospelliergilles self-assigned this Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 98.41% and project coverage change: +0.04 🎉

Comparison is base (ec6abfe) 72.19% compared to head (0874ce0) 72.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   72.19%   72.23%   +0.04%     
==========================================
  Files        1620     1620              
  Lines      122115   122196      +81     
==========================================
+ Hits        88158    88270     +112     
+ Misses      33957    33926      -31     
Impacted Files Coverage Δ
arcane/src/arcane/impl/internal/VariableMng.h 97.05% <ø> (ø)
arcane/src/arcane/impl/VariableIOWriterMng.cc 88.60% <97.91%> (+2.14%) ⬆️
arcane/src/arcane/impl/VariableIOReaderMng.cc 90.02% <98.71%> (+1.61%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@grospelliergilles grospelliergilles merged commit c03ad34 into main Jun 30, 2023
45 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-add-json-for-variablemng-metadata branch July 5, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant