Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default values of 'ILoadBalanceMng' to make partitionning independant of the memory usage #1673

Merged

Conversation

grospelliergilles
Copy link
Member

@grospelliergilles grospelliergilles commented Oct 7, 2024

Before this PR, by default we use memory usage to make the initial partitioning. The memory usage depend of the number of cells variables allocated. So it makes the partitioning dependent of the loaded modules or the build mode (check/release).

We can restore the old default behavior when setting environment variable ARCANE_USE_LEGACY_INIT_LOADBALANCEMNG to 1.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Oct 7, 2024
@grospelliergilles grospelliergilles self-assigned this Oct 7, 2024
@grospelliergilles grospelliergilles force-pushed the dev/gg-use-by-default-nb-cell-for-initial-partitioning branch from a7c7e49 to 7f6d5ad Compare October 7, 2024 19:41
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 81.44330% with 36 lines in your changes missing coverage. Please review.

Project coverage is 69.95%. Comparing base (9602dde) to head (d5d4a8b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...src/arcane/impl/internal/LoadBalanceMngInternal.cc 87.40% 11 Missing and 5 partials ⚠️
arcane/src/arcane/std/MeshPartitionerBase.cc 41.66% 7 Missing ⚠️
.../src/arcane/impl/internal/LoadBalanceMngInternal.h 53.84% 6 Missing ⚠️
arcane/src/arcane/impl/LoadBalanceMng.cc 68.75% 5 Missing ⚠️
arcane/src/arcane/std/MetisGraphDigest.cc 92.30% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   69.95%   69.95%           
=======================================
  Files        2249     2249           
  Lines      160283   160282    -1     
  Branches    18475    18473    -2     
=======================================
  Hits       112132   112132           
+ Misses      41470    41469    -1     
  Partials     6681     6681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles force-pushed the dev/gg-use-by-default-nb-cell-for-initial-partitioning branch from 7f6d5ad to 80fa571 Compare October 8, 2024 12:47
…e historique d'initialisation du LoadBalanceMng.
@grospelliergilles grospelliergilles marked this pull request as ready for review October 8, 2024 13:54
@grospelliergilles grospelliergilles merged commit 567c7e4 into main Oct 8, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant