Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MPI communicator handling in alien external packages #1666

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

stdcm
Copy link
Member

@stdcm stdcm commented Oct 4, 2024

Use Arccore Communicator instead of casting MpiMessagePassingMng

@stdcm stdcm requested a review from gratienj October 4, 2024 12:27
@stdcm stdcm self-assigned this Oct 4, 2024
@stdcm stdcm added refactoring Code refactoring and cleanup alien Alien component labels Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.84%. Comparing base (2f0b1bf) to head (f34870f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../alien/kernels/hypre/data_structure/HypreMatrix.cc 0.00% 2 Missing ⚠️
.../alien/kernels/hypre/data_structure/HypreVector.cc 0.00% 2 Missing ⚠️
...packages/src/alien/kernels/petsc/io/AsciiDumper.cc 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1666   +/-   ##
=======================================
  Coverage   69.84%   69.84%           
=======================================
  Files        2249     2249           
  Lines      160522   160506   -16     
  Branches    18493    18493           
=======================================
- Hits       112112   112111    -1     
+ Misses      41729    41721    -8     
+ Partials     6681     6674    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…here arcane communicator is invalid (use MPI_COMM_WORLD).
…rccore Communicator instead of a cast into MpiMessagePassingMNg (not always valid).

 use PETSC_COMM_SELF when Arccore Communicator not valid).
…RCANE_PARALLEL_SERVICE=Mpi in Alien tests.

 Was needed by the cast into MpiMessagePassingMng (now removed).
@stdcm stdcm force-pushed the dev/sdc-update-mpi-comm-handling-in-alien branch from e377853 to f34870f Compare October 4, 2024 15:54
@stdcm stdcm merged commit dd1ae9c into main Oct 4, 2024
27 checks passed
@stdcm stdcm deleted the dev/sdc-update-mpi-comm-handling-in-alien branch October 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alien Alien component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant