Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mpi communicator access in Hypre matrix, vector and solver. #1657

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

stdcm
Copy link
Member

@stdcm stdcm commented Oct 2, 2024

  • Use IMessagePassingMng::communicator instead of a cast into MpiMessagePassingMng which only exists in standalone mode

@stdcm stdcm requested a review from gratienj October 2, 2024 08:18
@stdcm stdcm self-assigned this Oct 2, 2024
@stdcm stdcm added bug Something isn't working alien Alien component labels Oct 2, 2024
@stdcm stdcm force-pushed the dev/sdc-fix-hypre-matrix-vector-init branch from 023b088 to fdb4983 Compare October 2, 2024 08:36
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.66%. Comparing base (85386ae) to head (fdb4983).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../alien/kernels/hypre/data_structure/HypreMatrix.cc 33.33% 3 Missing and 1 partial ⚠️
.../alien/kernels/hypre/data_structure/HypreVector.cc 42.85% 3 Missing and 1 partial ⚠️
...s/hypre/linear_solver/HypreInternalLinearSolver.cc 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   69.66%   69.66%   -0.01%     
==========================================
  Files        2247     2247              
  Lines      160467   160476       +9     
  Branches    18486    18486              
==========================================
+ Hits       111794   111796       +2     
- Misses      42018    42021       +3     
- Partials     6655     6659       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdcm stdcm merged commit 496645f into main Oct 2, 2024
29 checks passed
@stdcm stdcm deleted the dev/sdc-fix-hypre-matrix-vector-init branch October 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alien Alien component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant