-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: image tag uses the default .Chart.AppVersion
#606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @takumakume
Thanks for this PR.
I left 1 comment. Take a look, when you have time, please.
deploy/helm/postee/values.yaml
Outdated
@@ -197,7 +197,7 @@ configuration: | |||
image: | |||
repository: aquasec/postee | |||
pullPolicy: Always | |||
tag: "2.12.0-amd64" | |||
# tag: "2.12.0-amd64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
@DmitriyLewen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for your work, @takumakume
@simar7 i approved this PR.
Ref: #605
Currently, the image tag in values.yaml is used instead of
.Chart.AppVersion
. This means that the tag must be incremented each time it is released.In this pull request, remove the tag specification in values.yaml and use the default
.Chart.AppVersion
.postee/deploy/helm/postee/templates/postee.yaml
Line 85 in 698003e
postee/deploy/helm/postee/templates/postee-ui.yaml
Line 43 in 698003e
The tag in values.yaml is commented out for documentation.