Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: image tag uses the default .Chart.AppVersion #606

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

takumakume
Copy link
Contributor

Ref: #605

Currently, the image tag in values.yaml is used instead of .Chart.AppVersion. This means that the tag must be incremented each time it is released.

In this pull request, remove the tag specification in values.yaml and use the default .Chart.AppVersion.

image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"

image: "{{ .Values.posteUi.image }}:{{ .Values.posteUi.tag | default .Chart.AppVersion }}"

The tag in values.yaml is commented out for documentation.

$ helm template deploy/helm/postee | grep 'image: "aquasec/postee' -A4 -B4
      containers:
        - name: postee
          securityContext:
            {}
          image: "aquasec/postee-ui:2.14.0-amd64"
          imagePullPolicy: Always
          env:
            - name: POSTEE_UI_CFG
              value: /data/cfg.yaml
--
      containers:
        - name: postee
          securityContext:
            {}
          image: "aquasec/postee:2.14.0-amd64"
          imagePullPolicy: Always
          env:
            - name: POSTEE_CFG
              value: /data/cfg.yaml

@takumakume takumakume mentioned this pull request Aug 21, 2023
4 tasks
Copy link
Collaborator

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @takumakume
Thanks for this PR.
I left 1 comment. Take a look, when you have time, please.

deploy/helm/postee/values.yaml Outdated Show resolved Hide resolved
@@ -197,7 +197,7 @@ configuration:
image:
repository: aquasec/postee
pullPolicy: Always
tag: "2.12.0-amd64"
# tag: "2.12.0-amd64"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@takumakume
Copy link
Contributor Author

@DmitriyLewen
Thank you for your review!
I have incorporated the content you suggested.

Copy link
Collaborator

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for your work, @takumakume
@simar7 i approved this PR.

@simar7 simar7 merged commit 0d1c8f1 into aquasecurity:main Aug 30, 2023
4 checks passed
@takumakume takumakume deleted the auto-bump-image-tag branch August 30, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants