Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LD-107] Extract mock-web-server-module. #216

Merged
merged 13 commits into from
May 10, 2024
Merged

Conversation

nowakweronika
Copy link
Collaborator

@nowakweronika nowakweronika commented Mar 12, 2024

Pull-Request

Description

Why?

We extracted MockWebServerRule to external library https://github.com/appunite/MockWebServer-Extensions.

What?

Removed code related to the MockWebServerRule and added MockWebServer-Extensions.

Links to related issues

Demo

Nothing to show :)

How to test

You can see the Run UI tests on Firebase Test Lab job passed.

Documentation

Checklist

  • Functionality is covered by unit tests
  • Functionality is covered by integration tests
  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

Copy link

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

Copy link

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

Copy link

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

Copy link

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

Copy link

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

Copy link

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

Copy link

github-actions bot commented May 8, 2024

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

@nowakweronika nowakweronika changed the title Extract mock-web-server-module. [LD-107] Extract mock-web-server-module. May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

@nowakweronika nowakweronika marked this pull request as ready for review May 8, 2024 18:18
Copy link

github-actions bot commented May 8, 2024

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

Copy link
Member

@jacek-marchwicki jacek-marchwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

github-actions bot commented May 9, 2024

Overall Project 72.72%
Module Coverage
app 86.8% 🍏
Files
Module File Coverage
app NetworkModule.kt 100% 🍏

@nowakweronika nowakweronika merged commit 768329f into develop May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants