New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LD-165] Change name of "success" param to "action_success". #215

Closed

nowakweronika wants to merge 1 commit into develop from change_success_param

Collaborator

nowakweronika commented Mar 12, 2024

Pull-Request

Description

Why?

We don't see the success parameter in the looker studio because it is a built-in parameter.

What?

Change the name of "success" parameter to "action_success".
Add "action_success" parameter to custom definitions.

Links to related issues

Fixes LD-165

Demo

Before the PR	After the PR

How to test

Check out the looker studio dashboard to see the success rate of actions.

Documentation

Checklist

Functionality is covered by unit tests
Functionality is covered by integration tests
I've updated PR description with relevant information
I've done self code review
I've manually tested if the code and app works


          Change name of "success" param to "action_success".

37c83f5

github-actions bot commented Mar 12, 2024

Overall Project	72.76% `-0.08%`	❌
Files changed	85.71%	🍏

Module	Coverage
app	86.81% `-0.15%`	🍏

Files

Module	File	Coverage
app	AuthenticatingEvents.kt	93.62%	🍏
	ReviewersEvents.kt	82.35% `-1.31%`	🍏
	PullRequestsEvents.kt	75.47% `-1.89%`	❌

nowakweronika closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet