Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LD-164] Change type of id to Long. #214

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

nowakweronika
Copy link
Collaborator

@nowakweronika nowakweronika commented Mar 11, 2024

Pull-Request

Description

Why?

Can't load pull requests.
Error:
Illegal input: Unexpected JSON token at offset 505: Failed to parse int for input '2173655898' at path: $.items[0].id
JSON input: .....dius/pull/213","id":2173655898,"node_id":"PR_kwDOJAD97s5o9HE.....

What?

Change type of id from Int to Long.

Links to related issues

Demo

Before the PR After the PR
Screenshot 2024-03-11 at 15 24 42 Screenshot 2024-03-11 at 15 28 41

How to test

  • Step 1: Log in to Loudius.
  • Step 2: Check if you can see pull requests.

Documentation

  • no docs

Checklist

  • Functionality is covered by unit tests
    - [ ] Functionality is covered by integration tests
  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

Copy link

Overall Project 72.76%
Files changed 100% 🍏

Module Coverage
app 86.81% 🍏
Files
Module File Coverage
app PullRequestsViewModel.kt 92.65% 🍏
PullRequest.kt 73.37% 🍏

@nowakweronika nowakweronika marked this pull request as ready for review March 11, 2024 14:41
@nowakweronika nowakweronika merged commit 0ec85eb into develop Mar 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants