Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LD-141 Fix develop branch after merging #129 #167

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jacek-marchwicki
Copy link
Member

@jacek-marchwicki jacek-marchwicki commented Oct 27, 2023

Pull-Request

Description

Why?

Develop branch is failing after merging #129 :
7af6feb

What?

Add simple fix for one test. Other test does have the current annotation.

Links to related issues

Demo

Look at the CI status - it is green again :)

How to test

You don't need to test the app itself, because it's only test suite change

Documentation

Nothing to add here ;)

Checklist

  • Functionality is covered by unit tests
    - [ ] Functionality is covered by integration tests
  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 3.67s
✅ REPOSITORY checkov yes no 18.5s
✅ REPOSITORY devskim yes no 1.15s
✅ REPOSITORY dustilock yes no 0.41s
✅ REPOSITORY gitleaks yes no 1.68s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 2.36s
✅ REPOSITORY syft yes no 0.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@jacek-marchwicki jacek-marchwicki marked this pull request as ready for review October 27, 2023 07:30
@jacek-marchwicki jacek-marchwicki merged commit 9349dc3 into develop Oct 27, 2023
11 of 12 checks passed
@jacek-marchwicki jacek-marchwicki deleted the fix-develop-ld-141 branch October 27, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants