Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration/gson to kotlinx.serialization #141

Closed
wants to merge 34 commits into from
Closed

Migration/gson to kotlinx.serialization #141

wants to merge 34 commits into from

Conversation

nowakweronika
Copy link
Collaborator

No description provided.

trOnk12 and others added 23 commits September 25, 2023 12:00
@trOnk12
add koin dependency
386d121
@trOnk12
create data source and network modules
42f163b
@trOnk12
revert the data soource and network modules hilt providers
dbab4de
@trOnk12
rebase
f811815
@trOnk12
add viewmodelmodule, use singleOf instead of single for simple injection
b7cdb4a
@trOnk12
use koinViewModel and create ViewModelModule
05b9baf
@trOnk12
rebase
cad6595
@trOnk12
pass modules to koin
e899247
@trOnk12
change names
2b4780d
@trOnk12
add check modules tests
2828975
@trOnk12
exclude viewmodel from test modules
0786d3a
@trOnk12
mock sharedprefs
e6b070c
@trOnk12
inject with koin remaining dependencies
5549d8c
@trOnk12
remove hilt dependencies
688d65f
@trOnk12
remove hilt imports
77d1871
@trOnk12
remove unnucessary hilt imports
53637a4
@trOnk12
remove unused imports
345e012
@nowakweronika
remove gson from gradle
b6b5b44
@nowakweronika
Merge branch 'koin/migrate_network' into migration/gson_to_kotlinx.se…
9afa456 
…rialization

# Conflicts:
#	app/src/main/java/com/appunite/loudius/di/NetworkModule.kt
#	app/src/main/java/com/appunite/loudius/network/utils/ApiRequester.kt
@nowakweronika
auth kotlinx serialization implementation
d1e9f1b
@nowakweronika
add logs
7d2742a
@nowakweronika
Merge branch 'develop' into migration/gson_to_kotlinx.serialization
80ad1e9 
# Conflicts:
#	app/build.gradle
#	app/src/main/java/com/appunite/loudius/ui/authenticating/AuthenticatingScreen.kt
#	app/src/main/java/com/appunite/loudius/ui/login/LoginScreen.kt
#	app/src/main/java/com/appunite/loudius/ui/pullrequests/PullRequestsScreen.kt
#	app/src/main/java/com/appunite/loudius/ui/reviewers/ReviewersScreen.kt
#	build.gradle
@nowakweronika
add LocalDateTime formatter
3d8507e
@github-actions
Copy link

Snapshot testing result: ✔️
Everything looks good!

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 2.86s
✅ KOTLIN ktlint 48 0 0 98.3s
✅ REPOSITORY checkov yes no 18.38s
✅ REPOSITORY devskim yes no 1.0s
✅ REPOSITORY dustilock yes no 0.19s
✅ REPOSITORY gitleaks yes no 1.42s
✅ REPOSITORY git_diff yes no 0.09s
✅ REPOSITORY secretlint yes no 2.16s
✅ REPOSITORY syft yes no 0.36s
✅ SPELL misspell 48 0 0 0.1s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@nowakweronika nowakweronika deleted the migration/gson_to_kotlinx.serialization branch November 16, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowakweronika @trOnk12