Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a twitter compose ruleset #134

Closed
wants to merge 52 commits into from

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Sep 28, 2023

Description

  • To make sure we are not doing any jetpack compose pitfalls, there is a twitter compose ruleset that we can use.

https://twitter.github.io/compose-rules/rules/

Why?

  • Add the twitter compose ruleset to be ran by ktlint to our custom rules set.

Links to related issues

Demo

Before the PR After the PR

Documentation

  • Link to documentation: Add link here
  • Link to figma: Add link here
  • Add here other useful documentation links that are useful for PR reviewer

Checklist

  • New functionality is covered by Analytics events
  • Analytics events are documented
  • Analytics dashboard is updated
  • Functionality covered by unit tests
  • I have manually tested if the code works

@github-actions
Copy link

Snapshot testing result: ✔️
Everything looks good!

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.3s
✅ COPYPASTE jscpd yes no 4.38s
✅ JSON eslint-plugin-jsonc 3 0 0 3.62s
✅ JSON jsonlint 3 0 0.47s
✅ JSON prettier 3 0 0 1.97s
✅ JSON v8r 3 0 4.5s
❌ KOTLIN ktlint 107 2 107 463.93s
⚠️ MARKDOWN markdownlint 3 0 19 0.97s
❌ MARKDOWN markdown-link-check 3 5 2.73s
✅ MARKDOWN markdown-table-formatter 3 0 0 0.54s
✅ REPOSITORY checkov yes no 26.91s
✅ REPOSITORY devskim yes no 1.35s
✅ REPOSITORY dustilock yes no 0.32s
✅ REPOSITORY gitleaks yes no 1.84s
✅ REPOSITORY git_diff yes no 0.13s
✅ REPOSITORY secretlint yes no 5.08s
✅ REPOSITORY syft yes no 1.19s
✅ SPELL misspell 146 0 0 0.31s
✅ XML xmllint 18 0 0 0.1s
✅ YAML prettier 9 1 0 1.71s
✅ YAML v8r 9 0 10.18s
✅ YAML yamllint 9 0 0.77s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@trOnk12 trOnk12 changed the title add a twitter ruleset chore: add a twitter compose ruleset Sep 28, 2023
Comment on lines 7 to 8
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was required by twitter compose rules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not anymore, reverted it back to what it was

@trOnk12
Copy link
Contributor Author

trOnk12 commented Oct 2, 2023

not working as for now ;s

@trOnk12 trOnk12 marked this pull request as draft October 2, 2023 12:55
@trOnk12
Copy link
Contributor Author

trOnk12 commented Oct 5, 2023

closing due to being unable to resolve the issues with adding the twitter compose rules

@trOnk12 trOnk12 closed this Oct 5, 2023
@trOnk12 trOnk12 deleted the chore/ktlint_twitter_rules branch October 5, 2023 09:26
@trOnk12 trOnk12 restored the chore/ktlint_twitter_rules branch October 10, 2023 22:42
@nowakweronika nowakweronika deleted the chore/ktlint_twitter_rules branch February 9, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants