adjust tests

appunite · Oct 27, 2023 · ef327f9 · ef327f9
1 parent 3966243
commit ef327f9
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/app/src/main/java/com/appunite/loudius/di/AnalyticsModule.kt b/app/src/main/java/com/appunite/loudius/di/AnalyticsModule.kt
@@ -8,7 +8,7 @@ import org.koin.dsl.module
 
 val analyticsModule = module {
     single<AnalyticsService> {
-        val firebaseAnalytics: FirebaseAnalytics = FirebaseAnalytics.getInstance(androidContext())
-        AnalyticsServiceImpl(firebaseAnalytics)
+        AnalyticsServiceImpl(get())
     }
+    single<FirebaseAnalytics> { FirebaseAnalytics.getInstance(androidContext()) }
 }
diff --git a/app/src/test/java/com/appunite/loudius/di/CheckModulesTest.kt b/app/src/test/java/com/appunite/loudius/di/CheckModulesTest.kt
@@ -20,8 +20,11 @@ import android.content.Context
 import android.content.SharedPreferences
 import com.appunite.loudius.appModule
 import com.appunite.loudius.util.MainDispatcherExtension
+import com.google.firebase.analytics.FirebaseAnalytics
 import io.mockk.every
+import io.mockk.mockk
 import io.mockk.mockkClass
+import io.mockk.mockkStatic
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
 import org.koin.dsl.koinApplication
@@ -35,15 +38,18 @@ class CheckModulesTest : KoinTest {
     fun verifyKoinApp() {
         val mockContext = mockkClass(Context::class)
         val mockSharedPref = mockkClass(SharedPreferences::class)
-
         every { mockContext.getSharedPreferences(any(), any()) } returns mockSharedPref
 
+        val mockFirebaseAnalytics = mockk<FirebaseAnalytics>()
+        mockkStatic(FirebaseAnalytics::class)
+        every { FirebaseAnalytics.getInstance(any()) } returns mockFirebaseAnalytics
+
         koinApplication {
             modules(
                 appModule
             )
 
-            checkModules() {
+            checkModules {
                 withInstance(mockContext)
             }
         }

diff --git a/app/src/test/java/com/appunite/loudius/ui/pullrequests/PullRequestsViewModelTest.kt b/app/src/test/java/com/appunite/loudius/ui/pullrequests/PullRequestsViewModelTest.kt
@@ -16,13 +16,15 @@
 
 package com.appunite.loudius.ui.pullrequests
 
+import com.appunite.loudius.analytics.AnalyticsService
 import com.appunite.loudius.fakes.FakePullRequestRepository
 import com.appunite.loudius.network.utils.WebException
 import com.appunite.loudius.util.Defaults
 import com.appunite.loudius.util.MainDispatcherExtension
 import com.appunite.loudius.util.neverCompletingSuspension
 import io.mockk.clearMocks
 import io.mockk.coEvery
+import io.mockk.mockk
 import io.mockk.spyk
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.test.runTest
@@ -40,7 +42,8 @@ import strikt.assertions.single
 @ExtendWith(MainDispatcherExtension::class)
 class PullRequestsViewModelTest {
     private val pullRequestRepository = spyk(FakePullRequestRepository())
-    private fun createViewModel() = PullRequestsViewModel(pullRequestRepository)
+    private val analyticsService = mockk<AnalyticsService>(relaxed = true)
+    private fun createViewModel() = PullRequestsViewModel(pullRequestRepository, analyticsService)
 
     @Test
     fun `WHEN refresh data THEN start refreshing data and set isRefreshing to true`() = runTest {

diff --git a/app/src/test/java/com/appunite/loudius/ui/reviewers/ReviewersViewModelTest.kt b/app/src/test/java/com/appunite/loudius/ui/reviewers/ReviewersViewModelTest.kt
@@ -17,6 +17,7 @@
 package com.appunite.loudius.ui.reviewers
 
 import androidx.lifecycle.SavedStateHandle
+import com.appunite.loudius.analytics.AnalyticsService
 import com.appunite.loudius.fakes.FakePullRequestRepository
 import com.appunite.loudius.network.model.RequestedReviewersResponse
 import com.appunite.loudius.network.utils.WebException
@@ -61,8 +62,9 @@ class ReviewersViewModelTest {
         every { get<String>("pull_request_number") } returns "correctPullRequestNumber"
     }
     private lateinit var viewModel: ReviewersViewModel
+    private val analyticsService = mockk<AnalyticsService>(relaxed = true)
 
-    private fun createViewModel() = ReviewersViewModel(repository, savedStateHandle)
+    private fun createViewModel() = ReviewersViewModel(repository, savedStateHandle, analyticsService)
 
     @BeforeEach
     fun setup() {