Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue UnimplementedInterfaceMethod: Method getsupportedtypes is not defined #385

Merged
merged 5 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# CHANGELOG
## [3.0.8](https://github.com/apigee/apigee-client-php/milestone/32?closed=1)
* [#379] Update option-resolver's symfony component version to its latest.

## [3.0.7](https://github.com/apigee/apigee-client-php/milestone/31?closed=1)
* [#374] Bump minimum required version of symfony/serializer.
* [#376] Remove symfony/serializer conflict and bump version.
Expand Down
10 changes: 10 additions & 0 deletions src/Api/ApigeeX/Denormalizer/AppGroupMembershipDenormalizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
/**
* Denormalizes appgroup membership data.
*/
class AppGroupMembershipDenormalizer implements DenormalizerInterface

Check failure on line 27 in src/Api/ApigeeX/Denormalizer/AppGroupMembershipDenormalizer.php

View workflow job for this annotation

GitHub Actions / test_and_lint (8.2, )

MethodSignatureMismatch

src/Api/ApigeeX/Denormalizer/AppGroupMembershipDenormalizer.php:27:7: MethodSignatureMismatch: Method Apigee\Edge\Api\ApigeeX\Denormalizer\AppGroupMembershipDenormalizer::supportsDenormalization with return type '' is different to return type 'bool' of inherited method Symfony\Component\Serializer\Normalizer\DenormalizerInterface::supportsDenormalization (see https://psalm.dev/042)

Check failure on line 27 in src/Api/ApigeeX/Denormalizer/AppGroupMembershipDenormalizer.php

View workflow job for this annotation

GitHub Actions / test_and_lint (8.3, )

MethodSignatureMismatch

src/Api/ApigeeX/Denormalizer/AppGroupMembershipDenormalizer.php:27:7: MethodSignatureMismatch: Method Apigee\Edge\Api\ApigeeX\Denormalizer\AppGroupMembershipDenormalizer::supportsDenormalization with return type '' is different to return type 'bool' of inherited method Symfony\Component\Serializer\Normalizer\DenormalizerInterface::supportsDenormalization (see https://psalm.dev/042)
{
/**
* {@inheritdoc}
Expand Down Expand Up @@ -61,4 +61,14 @@

return AppGroupMembership::class === $type || $type instanceof AppGroupMembership;
}

/**
* {@inheritdoc}
*/
public function getSupportedTypes(?string $format): array
{
return [
AppGroupMembership::class => true,
];
}
}
10 changes: 10 additions & 0 deletions src/Api/Management/Query/StatsQueryNormalizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,14 @@ public function supportsNormalization($data, $format = null)
{
return $data instanceof StatsQuery;
}

/**
* {@inheritdoc}
*/
public function getSupportedTypes(?string $format): array
{
return [
StatsQuery::class => true,
];
}
}
2 changes: 1 addition & 1 deletion src/ClientInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ interface ClientInterface extends HttpClient
*/
public const APIGEE_ON_GCP_ENDPOINT = 'https://apigee.googleapis.com/v1';

public const VERSION = '3.0.7';
public const VERSION = '3.0.8';

/**
* Allows access to the last request, response and exception.
Expand Down
10 changes: 10 additions & 0 deletions src/Serializer/EntitySerializer.php
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,16 @@ public function supportsEncoding($format): bool
return $this->format === $format && $this->serializer->supportsEncoding($format);
}

/**
* {@inheritdoc}
*/
public function getSupportedTypes(?string $format): array
{
return [
EntitySerializerInterface::class => true,
];
}

/**
* Allows subclasses to replace the default JSON encoder.
*
Expand Down
Loading