Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving the next list items based on 'nextpagetoken' flag #347

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

shishir-intelli
Copy link
Collaborator

@shishir-intelli shishir-intelli commented Jan 29, 2024

apigee/apigee-edge-drupal#1028
Fix #351
Retrieving the next list items based on nextpagetoken flag to prevent unnecessary API calls and added default pageSize to 1000.

@shishir-intelli shishir-intelli added the bug Something isn't working label Jan 29, 2024
@shishir-intelli shishir-intelli added this to the 3.0.5 milestone Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f0b1790) 87.71% compared to head (dfa2bf0) 87.56%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #347      +/-   ##
============================================
- Coverage     87.71%   87.56%   -0.16%     
- Complexity     1751     1753       +2     
============================================
  Files           349      349              
  Lines          4713     4711       -2     
============================================
- Hits           4134     4125       -9     
- Misses          579      586       +7     
Flag Coverage Δ
unittests 87.56% <50.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/Api/ApigeeX/Controller/PaginationHelperTrait.php 80.00% <50.00%> (-17.62%) ⬇️

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit d70542e into apigee:3.x Feb 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Team apps listing not showing more than 1000 apps in Apigee X
2 participants