Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when AppGroup list is empty or do not returns appgroups array - 2x #329

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Closes #325 for 2x

@shishir-intelli shishir-intelli added the bug Something isn't working label Dec 5, 2023
@shishir-intelli shishir-intelli added this to the 2.1.3 milestone Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #329 (ab99f20) into 2.x (2b3b7a6) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #329   +/-   ##
=========================================
  Coverage     87.55%   87.55%           
- Complexity     1727     1728    +1     
=========================================
  Files           349      349           
  Lines          4613     4613           
=========================================
  Hits           4039     4039           
  Misses          574      574           
Flag Coverage Δ
unittests 87.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/Api/ApigeeX/Controller/PaginationHelperTrait.php 97.61% <100.00%> (ø)

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 2691042 into apigee:2.x Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants