Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of pagination for Apigee X Teams for 3x #298

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Implementation of pagination for Apigee X Teams for 3x #298

merged 4 commits into from
Aug 22, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Closes #287

@shishir-intelli shishir-intelli added the enhancement New feature or request label Aug 22, 2023
@shishir-intelli shishir-intelli added this to the 3.0.1 milestone Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #298 (aa74152) into 3.x (0815d21) will decrease coverage by 0.83%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #298      +/-   ##
============================================
- Coverage     84.69%   83.86%   -0.83%     
- Complexity     1718     1727       +9     
============================================
  Files           345      348       +3     
  Lines          4579     4624      +45     
============================================
  Hits           3878     3878              
- Misses          701      746      +45
Flag Coverage Δ
unittests 83.86% <0.00%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Api/ApigeeX/Controller/AppGroupController.php 0.00% <0.00%> (ø)
...i/ApigeeX/Controller/PaginatedEntityController.php 0.00% <0.00%> (ø)
...ntroller/PaginatedEntityListingControllerTrait.php 0.00% <0.00%> (ø)
...c/Api/ApigeeX/Controller/PaginationHelperTrait.php 0.00% <0.00%> (ø)

divya-intelli
divya-intelli approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 7609cd4 into apigee:3.x Aug 22, 2023
5 of 6 checks passed
@shishir-intelli shishir-intelli deleted the pagination3x branch August 23, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-intelli divya-intelli divya-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

@kedarkhaire kedarkhaire Awaiting requested review from kedarkhaire

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

Implement pagination for Apigee X Teams
2 participants
@shishir-intelli @divya-intelli