Refactor make code more idiomatic #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the contribution is substantial, and following the usage instructions described in https://www.gnu.org/licenses/gpl-howto.html
These lists of files are not modified often, and the Git versions are cryptic enough to allow useless files to be added to the gem.
The entry points for the gem are: - the executable, which depends on the FileLoader and Server - the include in the hooks files, which I suggest taking care of later I think that the executable should probably not know about the internal organization of the gem, but it's mostly matter of appreciation (YMMV).
The FileLoader.unique_paths is not part of its API and should not be used by other classes/modules.
Asserting on the objects class is not used much in Ruby, and in this case it was used in case 'hooks' were nil. Instead, 'hooks' could default to an empty array (which conveys more meaning that nil) and it would always responds to "#each". The solution only builds on top of the existing duplication, but that's a different problem.
Minor use parens around arguments in method definitions and non-trivial method calls.
Minor refactor use Array#inject to group statements Minor use parens in multi-arguments method calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a Ruby developer
In order to make the gem maintenance easier
I want its code to be as simple as possible
And as idiomatic as possible
See #13
Fixes #9