Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Signed APIs and Providers #838

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Document Signed APIs and Providers #838

merged 6 commits into from
Oct 16, 2024

Conversation

Ashar2shahid
Copy link
Contributor

Documenting Signed APIs based on #831 and also documenting new providers

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Visit the preview URL for this PR (updated for commit 0a718e6):

https://vitepress-docs--pr838-signed-apis-document-a0dw9ywa.web.app

(expires Wed, 23 Oct 2024 15:43:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Copy link
Member

@wkande wkande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A few minor suggestions.

docs/reference/dapis/understand/signed-apis.md Outdated Show resolved Hide resolved
docs/reference/dapis/understand/signed-apis.md Outdated Show resolved Hide resolved
docs/reference/dapis/understand/signed-apis.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ashar, 👍 LGTM

@Ashar2shahid Ashar2shahid merged commit efe6713 into main Oct 16, 2024
1 check passed
@Ashar2shahid Ashar2shahid deleted the signed_apis_document branch October 16, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants