-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dividers between languages #497
base: master
Are you sure you want to change the base?
Conversation
Also, I could not make it to creating an account inside the Appertium Wiki and MediaWiki (the latter says incorrect captcha although it is 100% correct). Is there any other way of creating it with the help of mentors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't require modifying the DOM at all. It should be possible with just CSS changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems much more reasonable.
I think it should be a bit lighter.
I'd see what @jonorthwash thinks.
@@ -228,6 +228,7 @@ const LangsDropdown = ({ | |||
</button>, | |||
); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this change?
Pull Request Test Coverage Report for Build 8392470054Details
💛 - Coveralls |
The dividers separating varieties (e.g., for Occitan, Panjabi, etc.) should be different from those separating languages. I don't totally love separators, but I agree that something would be nice here. It doesn't look as clean, even though it is clearer. How does Google (or other bigger site) deal with this problem? |
Hello!
This is my solution to the Issue #441
I tried both options proposed by Jonathan and,
I think we should go with adding a divider between languages as it looks cleaner and clearer. Below is the screenshot for this solution
However, I think you should also take a look at how solution with divider looks like: