Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dividers between languages #497

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nrakhay
Copy link

@nrakhay nrakhay commented Mar 21, 2024

Hello!

This is my solution to the Issue #441
I tried both options proposed by Jonathan and,

I think we should go with adding a divider between languages as it looks cleaner and clearer. Below is the screenshot for this solution

Screenshot 2024-03-21 at 22 10 19

However, I think you should also take a look at how solution with divider looks like:
Screenshot 2024-03-21 at 22 13 17

@nrakhay
Copy link
Author

nrakhay commented Mar 21, 2024

Also, I could not make it to creating an account inside the Appertium Wiki and MediaWiki (the latter says incorrect captcha although it is 100% correct).

Is there any other way of creating it with the help of mentors?

@jonorthwash

Copy link
Member

@sushain97 sushain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't require modifying the DOM at all. It should be possible with just CSS changes.

@nrakhay
Copy link
Author

nrakhay commented Mar 22, 2024

I returned things how they were on the DOM level and added a divider using :after in CSS

image

Copy link
Member

@sushain97 sushain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems much more reasonable.

I think it should be a bit lighter.

I'd see what @jonorthwash thinks.

@@ -228,6 +228,7 @@ const LangsDropdown = ({
</button>,
);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8392470054

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.644%

Totals Coverage Status
Change from base Build 8354222802: 0.0%
Covered Lines: 1381
Relevant Lines: 1396

💛 - Coveralls

@jonorthwash
Copy link
Member

The dividers separating varieties (e.g., for Occitan, Panjabi, etc.) should be different from those separating languages.

I don't totally love separators, but I agree that something would be nice here. It doesn't look as clean, even though it is clearer. How does Google (or other bigger site) deal with this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants