servlet.py->apy.py #239
Merged
servlet.py->apy.py #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sushain97 i may have been a bit quick in renaming everywhere since I saw apy.py in the dpkg but servlet.py was still in the git package, maybe another solution would have been to simply install servlet.py. OTOH, servlet is kind of a generic and confusing name for the entry point of apy. WDYT |
sushain97
approved these changes
Aug 15, 2024
|
Looks like tests are passing now but mypy is unhappy: https://github.com/apertium/apertium-apy/actions/runs/10404433625/job/28825143106?pr=239. This is better than before though so let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renames servlet.py to apy.py
This PR fixes an issue caused by 715a000
The target was changed from servlet.py to apy.py, but the file was not renamed accordingly