Implement namespacing #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PHP CS Fixer to clean up code. Updated Travis configuration to work with new configuration. Update Composer configuration to work with new configuration. Overall tweaks in code to work with new naming conventions and fix minor bugs.
ikari7789
force-pushed
the
implement-namespacing
branch
from
f1280e0
to
1761dd2
Compare
|
Not sure if this can still be reused. There are a lot of conflicts here and #332 is using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #188 this is a work in progress that requires more input from all parties involved. At the current moment, I've dropped support for PHP < 5.4, but this could be fixed by re-adding
array()syntax instead of short array syntax[].