Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support JSON CQ Files and offset In-place Upgrade to RocksDB #8687

Closed
wants to merge 8 commits into from

Conversation

LetLetMe
Copy link
Contributor

@LetLetMe LetLetMe commented Sep 12, 2024

Which Issue(s) This PR Fixes

Fixes #8589

之前的讨论参考:#8600
Refer to the previous discussion at: #8600

Brief Description

How Did You Test This Change?

@LetLetMe LetLetMe changed the title cq双写 [Enhancement] Support JSON CQ Files and offset In-place Upgrade to RocksDB Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 24.63235% with 205 lines in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (ba8148f) to head (8b1161f).

Files with missing lines Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 61 Missing ⚠️
...mand/queue/CheckRocksdbCqWriteProgressCommand.java 0.00% 38 Missing ⚠️
...mq/broker/offset/RocksDBConsumerOffsetManager.java 52.94% 10 Missing and 6 partials ⚠️
...org/apache/rocketmq/store/RocksDBMessageStore.java 0.00% 15 Missing ⚠️
...org/apache/rocketmq/store/DefaultMessageStore.java 33.33% 11 Missing and 1 partial ⚠️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 0.00% 8 Missing ⚠️
...ache/rocketmq/store/config/MessageStoreConfig.java 41.66% 7 Missing ⚠️
.../subscription/RocksDBSubscriptionGroupManager.java 53.84% 4 Missing and 2 partials ⚠️
...cketmq/broker/topic/RocksDBTopicConfigManager.java 50.00% 4 Missing and 2 partials ⚠️
.../rocketmq/broker/offset/ConsumerOffsetManager.java 58.33% 3 Missing and 2 partials ⚠️
... and 11 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8687      +/-   ##
=============================================
- Coverage      47.55%   47.49%   -0.06%     
- Complexity     11546    11567      +21     
=============================================
  Files           1277     1280       +3     
  Lines          89449    89696     +247     
  Branches       11504    11540      +36     
=============================================
+ Hits           42535    42601      +66     
- Misses         41706    41873     +167     
- Partials        5208     5222      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LetLetMe
Copy link
Contributor Author

1111

@LetLetMe LetLetMe closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support JSON CQ Files and offset In-place Upgrade to RocksDB
2 participants