fix BitsArray upper boundary validate bug #8664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8664 +/- ##
=============================================
+ Coverage 47.44% 48.79% +1.34%
- Complexity 11515 12654 +1139
=============================================
Files 1277 1282 +5
Lines 89442 96028 +6586
Branches 11502 13257 +1755
=============================================
+ Hits 42436 46854 +4418
- Misses 41801 43690 +1889
- Partials 5205 5484 +279
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chi3316
reviewed
Sep 9, 2024
| @Test(expected = IllegalArgumentException.class) | ||
| public void testByteBoundaryOverflow() { | ||
| BitsArray bitsArray = BitsArray.create(16); | ||
| assertThat(bitsArray.byteLength() ).isEqualTo(2); |
chi3316
approved these changes
Sep 10, 2024
|
@chi3316 为啥集成测试失败了~我在本地看是没问题的 |
ci环境资源比较紧张，有时候会遇到一些测试偶发性失败的问题。可以试着改动几个空行再提交来重新触发一下ci |
lizhimins
reviewed
Sep 25, 2024
| @@ -195,7 +195,7 @@ protected int position(int bitPos) { | |||
|
|
|||
| protected void checkBytePosition(int bytePos, BitsArray bitsArray) { | |||
| checkInitialized(bitsArray); | |||
| if (bytePos > bitsArray.byteLength()) { | |||
| if (bytePos >= bitsArray.byteLength()) { | |||
| throw new IllegalArgumentException("BytePos is greater than " + bytes.length); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix BitsArray upper boundary validate bug