Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8615] fix DeleteUserSubCommand command failed when acl2.0 authentication enabled and authorization disabled #8616

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kingkh1995
Copy link
Contributor

@kingkh1995 kingkh1995 commented Aug 30, 2024

Which Issue(s) This PR Fixes

Fixes #8615

Brief Description

How Did You Test This Change?

@kingkh1995
Copy link
Contributor Author

@dingshuangxi888 can you please review my pr?

@kingkh1995 kingkh1995 changed the title #8615 fix DeleteUserSubCommand command failed when acl2.0 authentication enabled [ISSUE #8615] fix DeleteUserSubCommand command failed when acl2.0 authentication enabled Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.33%. Comparing base (945e7ea) to head (743583b).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8616      +/-   ##
=============================================
- Coverage      47.53%   47.33%   -0.20%     
- Complexity     11551    11554       +3     
=============================================
  Files           1279     1283       +4     
  Lines          89562    89874     +312     
  Branches       11516    11564      +48     
=============================================
- Hits           42569    42546      -23     
- Misses         41773    42073     +300     
- Partials        5220     5255      +35     
Flag Coverage Δ
47.33% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuz10 yuz10 changed the title [ISSUE #8615] fix DeleteUserSubCommand command failed when acl2.0 authentication enabled [ISSUE #8615] fix DeleteUserSubCommand command failed when acl2.0 authentication enabled and authorization disabled Aug 31, 2024
@kingkh1995 kingkh1995 force-pushed the fix-acl2.0-deleteUser branch 6 times, most recently from 6d6a7c1 to 14ee16b Compare September 13, 2024 16:29
@kingkh1995 kingkh1995 force-pushed the fix-acl2.0-deleteUser branch 3 times, most recently from 916ac34 to ad1fd18 Compare September 22, 2024 15:00
…ntication enabled and authorization disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DeleteUserSubCommand command failed when acl2.0 authentication enabled and authorization disabled
2 participants