[ISSUE #776] Add push consumer for normal/fifo message, namespace support, reentrant message receiving support in C# SDK #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
2 times, most recently
from
04115b9
to
a1801b9
Compare
This was referenced Jul 2, 2024
tsunghanjacktsai
changed the title
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
from
a1801b9
to
79f8dd4
Compare
This was referenced Jul 3, 2024
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
4 times, most recently
from
835c8b8
to
98585a3
Compare
This was referenced Jul 23, 2024
tsunghanjacktsai
changed the title
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
3 times, most recently
from
73a8716
to
574f1b8
Compare
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
2 times, most recently
from
6bb3304
to
1e176ab
Compare
fuyou001
reviewed
Sep 2, 2024
|
|
||
| consumeTask.ContinueWith(task => | ||
| { | ||
| if (!task.IsFaulted) |
There was a problem hiding this comment.
Replace IsFaulted with IsCompletedSuccessfully
fuyou001
previously approved these changes
Sep 4, 2024
aaron-ai
previously approved these changes
Sep 9, 2024
|
Great to see such amazing work on the C# client! BTW,
Thanks @tsunghanjacktsai ! |
tsunghanjacktsai
dismissed stale reviews from aaron-ai and fuyou001
via
0effc2b
Thanks for the reply! I'll release a new version NuGet package once the PR has been merged. |
RongtongJin
previously approved these changes
Sep 12, 2024
added 6 commits
September 15, 2024 20:33
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
2 times, most recently
from
c5b7945
to
4e6d57b
Compare
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
8 times, most recently
from
99f5824
to
366dccb
Compare
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
3 times, most recently
from
33c6ac2
to
4b10cc7
Compare
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
from
4b10cc7
to
89a76cb
Compare
tsunghanjacktsai
force-pushed
the
csharp-sdk-optimization
branch
from
1be91d6
to
e593bdc
Compare
fuyou001
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes Issue #776
Brief Description
Add push consumer for normal message
How Did You Test This Change?
N/A