Remove unused method

apache · Oct 18, 2024 · 6bdb998 · 6bdb998
1 parent 5ae0f0f
commit 6bdb998
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 45 deletions.
diff --git a/polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java b/polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java
@@ -61,15 +61,6 @@ public abstract EnumMap<PolarisCredentialProperty, String> getSubscopedCreds(
       @NotNull Set<String> allowedReadLocations,
       @NotNull Set<String> allowedWriteLocations);
 
-  /**
-   * Describe the configuration for the current storage integration.
-   *
-   * @param storageConfigInfo the configuration info provided by the user.
-   * @return an enum map
-   */
-  public abstract EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
-      descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo storageConfigInfo);
-
   /**
    * Validate access for the provided operation actions and locations.
    *

diff --git a/...e/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java b/...e/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java
@@ -27,7 +27,6 @@
 import org.apache.polaris.core.PolarisDiagnostics;
 import org.apache.polaris.core.storage.InMemoryStorageIntegration;
 import org.apache.polaris.core.storage.PolarisCredentialProperty;
-import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
 import org.apache.polaris.core.storage.StorageUtil;
 import org.jetbrains.annotations.NotNull;
 import software.amazon.awssdk.policybuilder.iam.IamConditionOperator;
@@ -187,11 +186,4 @@ private String getArnPrefixFor(String roleArn) {
     }
     return path;
   }
-
-  // FIXME - we don't need this method in the interface
-  @Override
-  public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
-      descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo storageConfigInfo) {
-    return null;
-  }
 }
diff --git a/...c/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java b/...c/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java
@@ -47,7 +47,6 @@
 import org.apache.polaris.core.PolarisDiagnostics;
 import org.apache.polaris.core.storage.InMemoryStorageIntegration;
 import org.apache.polaris.core.storage.PolarisCredentialProperty;
-import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
 import org.jetbrains.annotations.NotNull;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -273,10 +272,4 @@ private AccessToken getAccessToken(String tenantId) {
     }
     return accessToken;
   }
-
-  @Override
-  public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
-      descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo storageConfigInfo) {
-    return null;
-  }
 }
diff --git a/...e/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java b/...e/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java
@@ -39,7 +39,6 @@
 import org.apache.polaris.core.PolarisDiagnostics;
 import org.apache.polaris.core.storage.InMemoryStorageIntegration;
 import org.apache.polaris.core.storage.PolarisCredentialProperty;
-import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
 import org.apache.polaris.core.storage.PolarisStorageIntegration;
 import org.apache.polaris.core.storage.StorageUtil;
 import org.jetbrains.annotations.NotNull;
@@ -207,10 +206,4 @@ public static CredentialAccessBoundary generateAccessBoundaryRules(
   private static String bucketResource(String bucket) {
     return "//storage.googleapis.com/projects/_/buckets/" + bucket;
   }
-
-  @Override
-  public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
-      descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo storageConfigInfo) {
-    return null;
-  }
 }
diff --git a/...is-core/src/test/java/org/apache/polaris/core/storage/InMemoryStorageIntegrationTest.java b/...is-core/src/test/java/org/apache/polaris/core/storage/InMemoryStorageIntegrationTest.java
@@ -197,12 +197,5 @@ public EnumMap<PolarisCredentialProperty, String> getSubscopedCreds(
         @NotNull Set<String> allowedWriteLocations) {
       return null;
     }
-
-    @Override
-    public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
-        descPolarisStorageConfiguration(
-            @NotNull PolarisStorageConfigurationInfo storageConfigInfo) {
-      return null;
-    }
   }
 }
diff --git a/...c/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java b/...c/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java
@@ -90,13 +90,6 @@ public EnumMap<PolarisCredentialProperty, String> getSubscopedCreds(
                 return new EnumMap<>(PolarisCredentialProperty.class);
               }
 
-              @Override
-              public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
-                  descPolarisStorageConfiguration(
-                      @NotNull PolarisStorageConfigurationInfo storageConfigInfo) {
-                return new EnumMap<>(PolarisStorageConfigurationInfo.DescribeProperty.class);
-              }
-
               @Override
               public @NotNull Map<String, Map<PolarisStorageActions, ValidationResult>>
                   validateAccessToLocations(