Enable ErrorProne MissingOverride (#103)

build-logic/src/main/kotlin/polaris-java.gradle.kts

@@ -31,7 +31,10 @@ tasks.withType(JavaCompile::class.java).configureEach {
   options.compilerArgs.addAll(listOf("-Xlint:unchecked", "-Xlint:deprecation"))
   options.errorprone.disableAllWarnings = true
   options.errorprone.disableWarningsInGeneratedCode = true
-  options.errorprone.error("StringCaseLocaleUsage")
+  options.errorprone.error(
+    "MissingOverride",
+    "StringCaseLocaleUsage",
+  )
 }
 
 tasks.register("format").configure { dependsOn("spotlessApply") }

extension/persistence/eclipselink/src/main/java/io/polaris/extension/persistence/impl/eclipselink/EclipseLinkPolarisMetaStoreManagerFactory.java

@@ -38,10 +38,12 @@ public class EclipseLinkPolarisMetaStoreManagerFactory
   @JsonProperty("persistence-unit")
   private String persistenceUnitName;
 
+  @Override
   protected PolarisEclipseLinkStore createBackingStore(@NotNull PolarisDiagnostics diagnostics) {
     return new PolarisEclipseLinkStore(diagnostics);
   }
 
+  @Override
   protected PolarisMetaStoreSession createMetaStoreSession(
       @NotNull PolarisEclipseLinkStore store, @NotNull RealmContext realmContext) {
     return new PolarisEclipseLinkMetaStoreSessionImpl(

extension/persistence/eclipselink/src/main/java/io/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java

@@ -552,6 +552,7 @@ public List<PolarisEntityActiveRecord> lookupEntityActiveBatch(
   }
 
   /** {@inheritDoc} */
+  @Override
   public boolean hasChildren(
       @NotNull PolarisCallContext callContext,
       @Nullable PolarisEntityType entityType,

polaris-core/src/main/java/io/polaris/core/PolarisDefaultDiagServiceImpl.java

@@ -65,6 +65,7 @@ public RuntimeException fail(
    * @throws RuntimeException if `reference` is null
    */
   @Contract("null, _ -> fail")
+  @Override
   public <T> T checkNotNull(final T reference, final String signature) {
     return Preconditions.checkNotNull(reference, signature);
   }
@@ -82,6 +83,7 @@ public <T> T checkNotNull(final T reference, final String signature) {
    * @throws RuntimeException if `reference` is null
    */
   @Contract("null, _, _, _ -> fail")
+  @Override
   public <T> T checkNotNull(
       final T reference,
       final String signature,
@@ -100,6 +102,7 @@ public <T> T checkNotNull(
    * @throws RuntimeException if `condition` is not true
    */
   @Contract("false, _ -> fail")
+  @Override
   public void check(final boolean expression, final String signature) {
     Preconditions.checkState(expression, signature);
   }
@@ -116,6 +119,7 @@ public void check(final boolean expression, final String signature) {
    * @throws RuntimeException if condition` is not true
    */
   @Contract("false, _, _, _ -> fail")
+  @Override
   public void check(
       final boolean expression,
       final String signature,

polaris-core/src/main/java/io/polaris/core/context/CallContext.java

@@ -135,6 +135,7 @@ public Map<String, Object> contextVariables() {
         contextVariables().computeIfAbsent(CLOSEABLES, key -> new CloseableGroup());
   }
 
+  @Override
   default void close() {
     if (CURRENT_CONTEXT.get() == this) {
       unsetCurrentContext();

polaris-core/src/main/java/io/polaris/core/entity/CatalogEntity.java

@@ -267,6 +267,7 @@ public Builder setStorageConfigurationInfo(
       return this;
     }
 
+    @Override
     public CatalogEntity build() {
       return new CatalogEntity(buildBase());
     }

polaris-core/src/main/java/io/polaris/core/entity/CatalogRoleEntity.java

@@ -58,6 +58,7 @@ public Builder(CatalogRoleEntity original) {
       super(original);
     }
 
+    @Override
     public CatalogRoleEntity build() {
       return new CatalogRoleEntity(buildBase());
     }

polaris-core/src/main/java/io/polaris/core/entity/NamespaceEntity.java

@@ -82,6 +82,7 @@ public Builder setParentNamespace(Namespace namespace) {
       return this;
     }
 
+    @Override
     public NamespaceEntity build() {
       return new NamespaceEntity(buildBase());
     }

polaris-core/src/main/java/io/polaris/core/entity/PolarisEntity.java

@@ -187,11 +187,13 @@ public PolarisEntity(@NotNull PolarisBaseEntity sourceEntity) {
   }
 
   @JsonIgnore
+  @Override
   public PolarisEntityType getType() {
     return PolarisEntityType.fromCode(getTypeCode());
   }
 
   @JsonIgnore
+  @Override
   public PolarisEntitySubType getSubType() {
     return PolarisEntitySubType.fromCode(getSubTypeCode());
   }
@@ -268,6 +270,7 @@ public Builder(PolarisEntity original) {
       super(original);
     }
 
+    @Override
     public PolarisEntity build() {
       return buildBase();
     }

polaris-core/src/main/java/io/polaris/core/entity/PrincipalEntity.java

@@ -75,6 +75,7 @@ public Builder setCredentialRotationRequiredState() {
       return this;
     }
 
+    @Override
     public PrincipalEntity build() {
       return new PrincipalEntity(buildBase());
     }

polaris-core/src/main/java/io/polaris/core/entity/PrincipalRoleEntity.java

@@ -62,6 +62,7 @@ public Builder(PrincipalRoleEntity original) {
       super(original);
     }
 
+    @Override
     public PrincipalRoleEntity build() {
       return new PrincipalRoleEntity(buildBase());
     }

polaris-core/src/main/java/io/polaris/core/entity/TableLikeEntity.java

@@ -77,6 +77,7 @@ public Builder(TableLikeEntity original) {
       super(original);
     }
 
+    @Override
     public TableLikeEntity build() {
       return new TableLikeEntity(buildBase());
     }

polaris-core/src/main/java/io/polaris/core/entity/TaskEntity.java

@@ -95,6 +95,7 @@ public Builder withLastAttemptStartedTimestamp(long timestamp) {
       return this;
     }
 
+    @Override
     public TaskEntity build() {
       return new TaskEntity(buildBase());
     }

polaris-core/src/main/java/io/polaris/core/persistence/PolarisMetaStoreManagerImpl.java

@@ -957,6 +957,7 @@ public Map<String, String> deserializeProperties(PolarisCallContext callCtx, Str
   }
 
   /** {@inheritDoc} */
+  @Override
   public @NotNull CreatePrincipalResult createPrincipal(
       @NotNull PolarisCallContext callCtx, @NotNull PolarisBaseEntity principal) {
     // get metastore we should be using

polaris-core/src/main/java/io/polaris/core/persistence/PolarisTreeMapMetaStoreSessionImpl.java

@@ -90,6 +90,7 @@ public void runActionInReadTransaction(
   /**
    * @return new unique entity identifier
    */
+  @Override
   public long generateNewId(@NotNull PolarisCallContext callCtx) {
     return this.store.getNextSequence();
   }
@@ -369,6 +370,7 @@ public List<PolarisEntityActiveRecord> lookupEntityActiveBatch(
   }
 
   /** {@inheritDoc} */
+  @Override
   public boolean hasChildren(
       @NotNull PolarisCallContext callContext,
       @Nullable PolarisEntityType entityType,

polaris-service/src/main/java/io/polaris/service/auth/BasePolarisAuthenticator.java

@@ -50,6 +50,7 @@ public abstract class BasePolarisAuthenticator
 
   protected RealmEntityManagerFactory entityManagerFactory;
 
+  @Override
   public void setEntityManagerFactory(RealmEntityManagerFactory entityManagerFactory) {
     this.entityManagerFactory = entityManagerFactory;
   }

polaris-service/src/main/java/io/polaris/service/auth/DefaultOAuth2ApiService.java

@@ -125,6 +125,7 @@ public void setEntityManagerFactory(RealmEntityManagerFactory entityManagerFacto
     }
   }
 
+  @Override
   public void setTokenBroker(TokenBrokerFactory tokenBrokerFactory) {
     this.tokenBrokerFactory = tokenBrokerFactory;
   }

polaris-service/src/main/java/io/polaris/service/auth/JWTBroker.java

@@ -51,6 +51,7 @@ abstract class JWTBroker implements TokenBroker {
 
   abstract Algorithm getAlgorithm();
 
+  @Override
   public DecodedToken verify(String token) {
     JWTVerifier verifier = JWT.require(getAlgorithm()).build();
     DecodedJWT decodedJWT = verifier.verify(token);

polaris-service/src/main/java/io/polaris/service/auth/TokenInfoExchangeResponse.java

@@ -34,6 +34,7 @@ public void setActive(boolean active) {
   private String scope;
 
   @JsonProperty("scope")
+  @Override
   public String getScope() {
     return scope;
   }
@@ -46,6 +47,7 @@ public void setScope(String scope) {
   private String clientId;
 
   @JsonProperty("client_id")
+  @Override
   public String getClientId() {
     return clientId;
   }
@@ -82,6 +84,7 @@ public void setExp(Long exp) {
   private String sub;
 
   @JsonProperty("sub")
+  @Override
   public String getSub() {
     return sub;
   }

polaris-service/src/test/java/io/polaris/service/catalog/BasePolarisCatalogTest.java

@@ -1037,6 +1037,7 @@ public void testDropNotificationWhenTableExists() {
   }
 
   @Test
+  @Override
   public void testDropTableWithPurge() {
     if (this.requiresNamespaceCreate()) {
       ((SupportsNamespaces) catalog).createNamespace(NS);