chore: Only verify Jdk 9 classes on jdk 11. #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
checkPublishLocalOpt
branch
2 times, most recently
from
ed51f6c
to
50074e8
Compare
He-Pin
force-pushed
the
checkPublishLocalOpt
branch
from
50074e8
to
65a6bf0
Compare
He-Pin
requested review from
mdedetrich,
jxnu-liguobin,
nvollmar and
pjfanning
Roiocam
approved these changes
Jan 29, 2024
| generateAndWriteScalaCLIScript( | ||
| target, | ||
| _ / "scala-cli" / "VerifyJDK9Classes.sc") | ||
| generateAndWriteScalaCLIScript(target) |
| exit 1 | ||
| ) | ||
| chmod +x .github/workflows/verify-jdk9-classes.sh | ||
| .github/workflows/verify-jdk9-classes.sh |
There was a problem hiding this comment.
Suggested change
| .github/workflows/verify-jdk9-classes.sh | |
| sh github/workflows/verify-jdk9-classes.sh |
There was a problem hiding this comment.
Let's keep it for now, otherwise I have to revaluation it.
|
|
||
| echo "Starting verification with Scala-CLI..." | ||
|
|
||
| for file in stream/target/scala-cli/*.sc; do |
There was a problem hiding this comment.
Cool, has expandable capability.
jxnu-liguobin
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Polish the script to test across all scala versions on JDK 11.
eg:
demo: https://github.com/apache/incubator-pekko/actions/runs/7694919153/job/20966708057?pr=1078