Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3007: Ensure version specific Jackson classes are shaded #3017

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

z-anderson
Copy link
Contributor

Rationale for this change
The current jar contains version specific classes under META-INF/versions/... with unshaded package names. This leads to clashes with jackson and thus classpath duplicates. This is a major problem in many big projects right now (e.g. Spark).

What changes are included in this PR?
Ensure these classes are shaded.

Are these changes tested?
Are there any user-facing changes?
Closes #3007

@gszadovszky
Copy link
Contributor

@z-anderson, could you add a comment here referencing your modification so we won't forget to update the shaded versions if needed?

@gszadovszky
Copy link
Contributor

@z-anderson, I've ment adding a comment in the master pom where jackson.version is specified. This way if someone would upgrade jackson, they won't forget to check the jdk versions inside the jar and potentially add new versions to include in the shading.

@gszadovszky gszadovszky merged commit fcfd427 into apache:master Sep 25, 2024
9 checks passed
@z-anderson
Copy link
Contributor Author

@gszadovszky Thank you! This is still blocking us. Are you able to release it soon please?

@gszadovszky
Copy link
Contributor

Sorry @z-anderson, I don't have time to guide a release. As @wgtmac suggested at the other PR, it should be discussed on the dev list.

@ted-jenks
Copy link

@gszadovszky @wgtmac @Fokko My emails are seemingly not making it through to the dev mailing list. This is really a big problem for us in Spark. Do you know why I am having trouble/does anyone have the bandwidth to help me out?

@wgtmac
Copy link
Member

wgtmac commented Sep 27, 2024

I have seen duplicate emails on the dev list. No worries, I can help with the release and just replied to the email you have sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version specific Jackson classes are left unshaded
4 participants