Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2326: Bump jcommander from 1.72 to 1.82 #1123

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Jul 15, 2023

Make sure you have checked all steps below.

Jira

A similar PR already exists (#1086) but it's not sufficient due to the API incompatibilities on the jcommander side.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No additional test since it's just a dependency upgrade. I ensured all of the existing tests succeeded with mvn clean install -f parquet-cli/pom.xml.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@wgtmac wgtmac merged commit 2cf7951 into apache:master Jul 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants