PARQUET-2325: Fix parquet-cli's dictionary subcommand to work with FI…

…XED_LEN_BYTE_ARRAY (#1122)
apache · Jul 16, 2023 · 2553978 · 2553978
1 parent 1bdb3c6
commit 2553978
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java b/parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java
@@ -98,6 +98,7 @@ private void printDictionary(Dictionary dict, PrimitiveType type) {
     for (int i = 0; i <= dict.getMaxId(); i += 1) {
       switch(type.getPrimitiveTypeName()) {
         case BINARY:
+        case FIXED_LEN_BYTE_ARRAY:
           if (type.getLogicalTypeAnnotation() instanceof LogicalTypeAnnotation.StringLogicalTypeAnnotation) {
             console.info("{}: {}", String.format("%6d", i),
                     Util.humanReadable(dict.decodeToBinary(i).toStringUsingUTF8(), 70));

diff --git a/parquet-cli/src/test/java/org/apache/parquet/cli/commands/ShowDictionaryCommandTest.java b/parquet-cli/src/test/java/org/apache/parquet/cli/commands/ShowDictionaryCommandTest.java
@@ -47,4 +47,14 @@ public void testShowDirectoryCommandWithoutDictionaryEncoding() throws IOExcepti
     command.setConf(new Configuration());
     Assert.assertEquals(0, command.run());
   }
+
+  @Test
+  public void testShowDirectoryCommandForFixedLengthByteArray() throws IOException {
+    File file = parquetFile();
+    ShowDictionaryCommand command = new ShowDictionaryCommand(createLogger());
+    command.targets = Arrays.asList(file.getAbsolutePath());
+    command.column = FIXED_LEN_BYTE_ARRAY_FIELD;
+    command.setConf(new Configuration());
+    Assert.assertEquals(0, command.run());
+  }
 }