Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BND configuration to pom.xml #3065

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Move BND configuration to pom.xml #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions log4j-1.2-api/bnd.bnd
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions log4j-1.2-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,12 @@
com.sun.jdmk.comm;resolution:=optional,
<!-- JMS is optional -->
javax.jms;version="[1.1,3)";resolution:=optional,
<!-- Log4j Core is optional -->
org.apache.logging.log4j.core.*;resolution:=optional
</bnd-extra-package-options>
<bnd-extra-module-options>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need an entry for javax.jms:javax.jms-api too?

<!-- Log4j Core is optional -->
org.apache.logging.log4j.core;static=true
</bnd-extra-module-options>
<Fragment-Host>org.apache.logging.log4j.core</Fragment-Host>
<!-- we have an `bnd.bnd` file to override the parent's defaults -->
</properties>

<dependencies>
Expand Down