Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iceberg source schema #97

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Iceberg source schema #97

merged 8 commits into from
Oct 25, 2023

Conversation

the-other-tim-brown
Copy link
Contributor

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

Addresses #62

Completes the support for all iceberg types currently supported in onetable

Brief change log

Adds support for

  • lists
  • maps
  • structs
  • uuids
  • fixed size byte arrays

Verify this pull request

Updated unit tests

ashvina
ashvina approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ashvina ashvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM 👍

@the-other-tim-brown the-other-tim-brown merged commit 867b0b7 into main Oct 25, 2023
1 check passed
@the-other-tim-brown the-other-tim-brown deleted the 62-iceberg-source-schema branch October 25, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashvina ashvina ashvina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-other-tim-brown @ashvina